Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added JMS source kamelet for Apache Artermis #363

Merged
merged 1 commit into from Jun 15, 2021
Merged

Added JMS source kamelet for Apache Artermis #363

merged 1 commit into from Jun 15, 2021

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Jun 14, 2021

No description provided.

@orpiske
Copy link
Contributor Author

orpiske commented Jun 14, 2021 •
edited

How the binding looks like: This is outdated and the sample is generated as part of the documentation.

@orpiske orpiske marked this pull request as draft June 14, 2021 10:24
oscerd
oscerd requested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the name to follow the kamelets naming convention. The content is ok.

@orpiske
Copy link
Contributor Author

orpiske commented Jun 14, 2021

Maybe change the name to follow the kamelets naming convention. The content is ok.

Cool, thanks for taking a look at it Andrea! I'll review the failing checks and put it according to the standard :)

@orpiske orpiske force-pushed the jms-source-kamelet branch 2 times, most recently from fb0dbb1 to 4afbaa2 Compare June 14, 2021 13:12
@orpiske orpiske marked this pull request as ready for review June 14, 2021 13:15
@orpiske orpiske force-pushed the jms-source-kamelet branch 3 times, most recently from 1013e0f to eaf4337 Compare June 15, 2021 06:59
@orpiske
Copy link
Contributor Author

orpiske commented Jun 15, 2021

This one is still broken. I am fixing it.

@orpiske
Copy link
Contributor Author

orpiske commented Jun 15, 2021

This one is still broken. I am fixing it.

It should be fine now. It had an extra file.

@orpiske
Copy link
Contributor Author

orpiske commented Jun 15, 2021

This and subsequent PRs will have conflicts on the nav file. I am watching for the approvals / comments and will be fixing the conflicts as they appear.

@orpiske orpiske force-pushed the jms-source-kamelet branch 2 times, most recently from b8e7b60 to 1a6aa98 Compare June 15, 2021 07:59
@orpiske
Copy link
Contributor Author

orpiske commented Jun 15, 2021

Maybe change the name to follow the kamelets naming convention. The content is ok.

Hey @oscerd, do we still have anything to change on this one? I think it's pretty much the same as the others ... I'm wondering if I missed anything.

oscerd
oscerd approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@orpiske
Copy link
Contributor Author

orpiske commented Jun 15, 2021

Lgtm

Thanks!

@orpiske orpiske merged commit 40a21b0 into apache:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orpiske @nicolaferraro @oscerd