Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MS SQL Server Sink Kamelet #366

Merged
merged 6 commits into from Jun 14, 2021
Merged

MS SQL Server Sink Kamelet #366

merged 6 commits into from Jun 14, 2021

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Jun 14, 2021

Fixes #364

nicolaferraro
nicolaferraro requested changes Jun 14, 2021
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put here and in the other SQL connectors some instructions. e.g. specifying that the input is expected to be JSON (in spec->types), an example in the query field and telling how the json fields are mapped to parameter values

sqlserver-sink.kamelet.yaml Outdated Show resolved Hide resolved
@oscerd
Copy link
Contributor Author

oscerd commented Jun 14, 2021

I'll rework the other connector by adding expecting type, query example and json mapping.

@oscerd
Copy link
Contributor Author

oscerd commented Jun 14, 2021

Let me merge and open other PRs.

@oscerd oscerd merged commit f950955 into main Jun 14, 2021
@oscerd oscerd deleted the sql-server branch July 2, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create MS SQL Server Sink Kamelet
2 participants
@oscerd @nicolaferraro