Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slack sink kamelet #429

Merged
merged 9 commits into from
Jul 16, 2021
Merged

Add slack sink kamelet #429

merged 9 commits into from
Jul 16, 2021

Conversation

doru1004
Copy link
Contributor

Add slack sink kamelet

oscerd
oscerd requested changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to add more options as optional like for example userName and iconEmoji.

@doru1004 doru1004 requested a review from oscerd July 16, 2021 18:34
oscerd
oscerd requested changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LazystartProducer doesn't really make sense in this context. It's something internal. I would remove it. Thanks. Overall looks good

@doru1004 doru1004 requested a review from oscerd July 16, 2021 19:18
nicolaferraro
nicolaferraro approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@nicolaferraro nicolaferraro merged commit da9dbaf into apache:main Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doru1004 @nicolaferraro @oscerd