[Website] Put block role in correct place in template #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Sep 3, 2021
|
The website build seems to fail now |
|
I think we need the other PR to be merged. |
|
For the moment I reverted the commit here: #481 Once we have everything merged I'll re-revert. |
|
Thanks, I’ll look into why that happened. nav files aren’t supposed to be picked up by the indexer query.
David Jencks
… On Sep 2, 2021, at 11:38 PM, Andrea Cosentino ***@***.***> wrote:
For the moment I reverted the commit here: #481 <#481>
Once we have everything merged I re-revert.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#480 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXTZDD2YIVOTAEF6T6LUABUQDANCNFSM5DKGODSA>.
|
|
I think the xref-checker is broken and causes this spurious error. I guess we could put the relative exclude back until we upgrade to Antora 3 alpha 9 and don’t need the xref checker any more, or merge this and the camel-website upgrade at the same time.
David Jencks
… On Sep 3, 2021, at 12:04 AM, David Jencks ***@***.***> wrote:
Thanks, I’ll look into why that happened. nav files aren’t supposed to be picked up by the indexer query.
David Jencks
> On Sep 2, 2021, at 11:38 PM, Andrea Cosentino ***@***.*** ***@***.***>> wrote:
>
>
> For the moment I reverted the commit here: #481 <#481>
> Once we have everything merged I re-revert.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <#480 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXTZDD2YIVOTAEF6T6LUABUQDANCNFSM5DKGODSA>.
>
|
|
I modified the PR to include the |
|
Thanks. I'll revert the revert and maybe you can open a new PR with the update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why the previous way of specifying the 'catalog' role/class worked with Asciidoctor 1.5.9 (Antora 2) but specifying the role inside the template works as expected in both Antora 2 and Antora 3.