Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamelets-doc-template-edit #538

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

MelissaFlinn
Copy link
Contributor

I have made some copy edits to the Kamelets doc template.
I also made some minor structure changes (for example, moved the dependencies into a higher level section).
And I tried to add an adoc variable (containercmd) to use for kubectl (upstream) and oc (downstream). I am not sure that this will work - might need to add a separate attributes.adoc file to handle the value for this and any future adoc variables.
I welcome all feedback.

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable substitution doesn't work. I don't think it is correct.

@MelissaFlinn
Copy link
Contributor Author

I removed the containercmd variable in the second commit

@MelissaFlinn
Copy link
Contributor Author

Thank you @oscerd - I do not have permission to merge this PR. Can you merge it or is there someone else that I should ask?

@oscerd
Copy link
Contributor

oscerd commented Oct 5, 2021

I'll do that but first i need to Regen the docs

@oscerd oscerd merged commit 65ee2e2 into apache:main Oct 6, 2021
@oscerd
Copy link
Contributor

oscerd commented Oct 6, 2021

Thanks, the docs have been regenerated.

@MelissaFlinn MelissaFlinn deleted the kamelets-doc-template-edit branch October 6, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants