Add Redis source kamelet #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Croway
force-pushed
the
redis-source-kamelet
branch
3 times, most recently
from
cff58c5
to
5a8aea3
Compare
oscerd
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
Looks good to me. You should build the entire tree so you should get the library updated with the kamelet.
Also you should run the script/generator with go run . ../../kamelets/ ../../docs/modules/ROOT/ and the validator go run . ../../kamelets/
Overall looks already good and thanks a lot!
Croway
force-pushed
the
redis-source-kamelet
branch
from
5a8aea3
to
0db53fc
Compare
|
oh nice, I didn't know about generators and validators, moreover your documentation generator write adoc much better then me |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.