Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix generated YAML and required props #6

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

nicolaferraro
Copy link
Member

No description provided.

@davsclaus
Copy link
Contributor

btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top).

@nicolaferraro
Copy link
Member Author

btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top).

Well, currently it should be alphabetical with required fields first... But we can think about it..

@nicolaferraro
Copy link
Member Author

nicolaferraro commented Feb 16, 2021

btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top).

Well, currently it should be alphabetical with required fields first... But we can think about it..

The problem is that it's a map that loses the order when unmarhsalled.. that's more a problem that happens e.g. on Kube, once you apply it you lose the order

@davsclaus
Copy link
Contributor

btw is the source code generated list of options in the same order as in the yaml file (eg so users may put the most important in the top).

Well, currently it should be alphabetical with required fields first... But we can think about it..

The problem is that it's a map that loses the order when unmarhsalled.. that's more a problem that happens e.g. on Kube, once you apply it you lose the order

ah okay A..Z is also fine, just that its the same.

We had that problem earlier in core camel where a regen would shuffle the options. So its best to have a fixed sorting in the build process

@nicolaferraro nicolaferraro merged commit 110f8bf into apache:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants