Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mail sink Kamelet #610

Merged
merged 1 commit into from Dec 8, 2021
Merged

Add mail sink Kamelet #610

merged 1 commit into from Dec 8, 2021

Conversation

christophd
Copy link
Contributor

No description provided.

oscerd
oscerd requested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sink yaml in kamelets seems to be different from the one copied in the library. Also i would probably use the same convention of having both ce headers and not supported

@oscerd
Copy link
Contributor

oscerd commented Dec 6, 2021

Looks good overall

@christophd christophd force-pushed the pr/mail-sink.kamelet branch 3 times, most recently from 3ce2d74 to 6366fbe Compare December 6, 2021 16:51
@christophd
Copy link
Contributor Author

@oscerd thanks fixed the kamelet sources. could you please approve the workflow run once more?

@oscerd
Copy link
Contributor

oscerd commented Dec 6, 2021

Done. Thanks.

@christophd
Copy link
Contributor Author

@oscerd previous workflow run was hanging due to issue with YAKS versioning. Could you please approve once more 🙏

this hanging workflow can be cancelled https://github.com/apache/camel-kamelets/runs/4433396398?check_suite_focus=true

@christophd
Copy link
Contributor Author

@oscerd forgot username and password as mandatory Kamelet properties. sorry for the trial end error. I think we are close to getting this test running green 🤞

@oscerd
Copy link
Contributor

oscerd commented Dec 6, 2021

No worries! Thanks a lot for your time!

@christophd
Copy link
Contributor Author

@oscerd please one more round of approval 🙏

@christophd
Copy link
Contributor Author

@oscerd ha, found a last issue. the test requires both timer-source and mail-sink Kamelet to be available in the namespace. Please approve once more.

@christophd
Copy link
Contributor Author

Wohooo! SUCCESS! @oscerd many thanks for staying with me

@oscerd
Copy link
Contributor

oscerd commented Dec 8, 2021

Happy to help

@oscerd oscerd merged commit 765bb2f into apache:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christophd @oscerd