Use OpenJDK 11 when building with JitPack #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Feb 28, 2022
|
I've had this in front of my eyes for months. I'm really lazy. |
|
you lazy? no way! I did not care about failing YAKS tests for long time. At least I am glad that the tests seem to point to the problem rigidly. Let's see if this has fixed the issues |
|
Not sure but I guess you'll need to merge anyway and then open a test PR to check. |
|
I think it is working as JitPack now uses JDK 11 on my branch: https://jitpack.io/com/github/christophd/camel-kamelets/3f2ed91323/build.log You are right that we need to merge here anyway to get the JitPack build also triggered for this repository |
|
@oscerd could you please merge. I do not have permissions to do so |
|
Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #792