Add Kamelet aws-ddb-sink #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Mar 15, 2022
|
|
||
| This Kamelet expects a JSON as body. The mapping between the JSON fields and table attribute values is done by key, so if you have the input: | ||
|
|
||
| '{"username":"oscerd", "city":"Rome"}' |
There was a problem hiding this comment.
Thanks for having me as example :-)
| * In case key and item attribute value maps are identical you can omit the special top level properties completely. | ||
| * The converter will map the whole Json body as is then and use it as source for the attribute value map. | ||
| */ | ||
| public class JsonToDdbModelConverter { |
There was a problem hiding this comment.
Looks really nice, thanks for this. I think we should move this kind of utility in the component at some point and recognize when we have a json payload.
...test/java/org/apache/camel/kamelets/utils/transform/aws/ddb/JsonToDdbModelConverterTest.java
Show resolved
Hide resolved
...test/java/org/apache/camel/kamelets/utils/transform/aws/ddb/JsonToDdbModelConverterTest.java
Outdated
Show resolved
Hide resolved
christophd
force-pushed
the
pr/aws-ddb-sink.kamelet
branch
from
14120c5
to
e4d094a
Compare
- Add sink Kamelet for AWS DynamoDB - Use YAKS version 0.9.0-202203140033 - Add integration test for aws-ddb-sink Kamelet - Introduce unit tests on camel-kamelets-utils module
- Use proper yaks-config conventions - Use YAKS dump functionality in case of failure - Move Camel K installation steps to workflow - Apply all current Kamelets at once in workflow prior to running the tests - Keep pre/post test scripts as simple as possible - Use Camel K 1.8.2 (fixes earthquake-source CI test)
christophd
force-pushed
the
pr/aws-ddb-sink.kamelet
branch
from
e4d094a
to
f0ddaa5
Compare
oscerd
approved these changes
Mar 16, 2022
|
Fixes #792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Add Kamelet aws-ddb-sink
Add sink Kamelet for AWS DynamoDB
Use YAKS version 0.9.0-202203140033
Add integration test for aws-ddb-sink Kamelet
Introduce unit tests on camel-kamelets-utils module
The Kamelet automatically converts Json body to proper AWS DynamoDB AttributeValue model. The Kamelet uses new utility class org.apache.camel.kamelets.utils.transform.aws.ddb.JsonToDdbModelConverter for this to happen. The PR tests are expected to fail because of this new utility class that is not available in main-SNAPSHOT JitPack repository yet.
Please have a look at the tests running successful on my fork branch where I was using a separate JitPack repository:
christophd#3
chore: Refactor YAKS tests
Also had to refactor YAKS tests in order to stabilize CI workflows: