[ISSUE-724] kafka-ssl-sink kamelet #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agiertli
changed the title
claudio4j
requested changes
Apr 7, 2022
| Both the headers are optional. | ||
| properties: | ||
| bootstrapServers: | ||
| description: Comma separated list of Kafka Broker URLs |
There was a problem hiding this comment.
Can you use kafka-sink.kamelet.yaml as source, then add the specific fields for SSL connection ? As the kafka-sink already contains some properties, this kafka-ssl-sink is going to extend it.
| - to: | ||
| parameters: | ||
| configuration: '#bean:{{kafka-ssl-sink-configuration-local}}' | ||
| uri: '{{kafka-ssl-sink-local}}:{{topic}}' |
There was a problem hiding this comment.
Can you please move "uri" to above "parameters" ?
There was a problem hiding this comment.
Uri is part of the yaml DSL and of the model, so it's not a parameter to list.
There was a problem hiding this comment.
@oscerd if I understand correctly no change is needed from my side on this one?
oscerd
requested changes
Apr 7, 2022
| - to: | ||
| parameters: | ||
| configuration: '#bean:{{kafka-ssl-sink-configuration-local}}' | ||
| uri: '{{kafka-ssl-sink-local}}:{{topic}}' |
There was a problem hiding this comment.
Uri is part of the yaml DSL and of the model, so it's not a parameter to list.
|
Fixes #724 |
oscerd
approved these changes
Apr 7, 2022
|
Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.