-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new kamelet that uses the nominatim geocoder #982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the type.
You mean the output type? I am not sure why the validation is failing, I am defining the objects there. |
You need to add the type: object to the definition like https://github.com/apache/camel-kamelets/blob/main/kamelets/aws-s3-sink.kamelet.yaml#L46 |
Is it not here? (line 59) Or is Edit: I see I deleted the |
I'm trying to mimic https://github.com/apache/camel-kamelets/blob/main/kamelets/salesforce-delete-sink.kamelet.yaml#L77-L87 but maybe I can't have an object inside an object? |
You need to add type: object in the kamelet definition. Types is a different thing as far as I know. |
I was too smart then. Let's see if that works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is wrong, type:object should be aligned with required.
Something else is missing, testing the validation locally now... (which I should have started with) |
eed5479
to
097526b
Compare
Finally! For the record: the And my local camel-k installation had no issue with any of those, btw. |
I created this kamelet because I want to use it on a demo next month. It has the geocoder camel component behind.
Given a URL of the geocoder server (Nominatim is FOSS and you can either deploy your own or use an existing one) as header and a text in the body, it searches for the geographic coordinates and the details of the address passed in the body.