Send unique messages in Slack itest to avoid false positive tests

apache · Aug 25, 2020 · 6818dd0 · 6818dd0
1 parent c839c72
commit 6818dd0
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/...-tests/slack/src/main/java/org/apache/camel/quarkus/component/slack/it/SlackResource.java b/...-tests/slack/src/main/java/org/apache/camel/quarkus/component/slack/it/SlackResource.java
@@ -20,6 +20,7 @@
 
 import javax.enterprise.context.ApplicationScoped;
 import javax.inject.Inject;
+import javax.ws.rs.Consumes;
 import javax.ws.rs.GET;
 import javax.ws.rs.POST;
 import javax.ws.rs.Path;
@@ -54,8 +55,9 @@ public String getSlackMessages() throws Exception {
 
     @Path("/message")
     @POST
+    @Consumes(MediaType.TEXT_PLAIN)
     public Response createSlackMessage(String message) throws Exception {
-        producerTemplate.requestBody("slack://general?" + SLACK_AUTH_PARAMS, "Hello Camel Quarkus Slack");
+        producerTemplate.requestBody("slack://general?" + SLACK_AUTH_PARAMS, message);
         return Response
                 .created(new URI("https://camel.apache.org/"))
                 .build();

diff --git a/...tion-tests/slack/src/test/java/org/apache/camel/quarkus/component/slack/it/SlackTest.java b/...tion-tests/slack/src/test/java/org/apache/camel/quarkus/component/slack/it/SlackTest.java
@@ -16,8 +16,11 @@
  */
 package org.apache.camel.quarkus.component.slack.it;
 
+import java.util.UUID;
+
 import io.quarkus.test.junit.QuarkusTest;
 import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
 import org.junit.jupiter.api.Test;
 
 import static org.hamcrest.CoreMatchers.equalTo;
@@ -39,13 +42,21 @@ class SlackTest {
 
     @Test
     public void testSlackProduceConsumeMessages() {
-        RestAssured.post("/slack/message")
+        final String message = "Hello Camel Quarkus Slack" + (externalSlackEnabled() ? " " + UUID.randomUUID() : "");
+        RestAssured.given()
+                .contentType(ContentType.TEXT)
+                .body(message)
+                .post("/slack/message")
                 .then()
                 .statusCode(201);
 
         RestAssured.get("/slack/messages")
                 .then()
                 .statusCode(200)
-                .body(equalTo("Hello Camel Quarkus Slack"));
+                .body(equalTo(message));
+    }
+
+    boolean externalSlackEnabled() {
+        return System.getenv("SLACK_WEBHOOK_URL") != null;
     }
 }