-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debezium MongoDB Connector native support #1190
Comments
Please, assign to me. |
Issue is blocked by the fact that debezium is using driver 3.x, but quarkus-mongodb-client uses 4.x. |
@JiriOndrusek do you have a proper test and is it passing the JVM mode at least? |
@ppalaga I have branch with tests. All tests for debezium-* extensions are gathered together to one integration-test module. I can review it, make sure it passes jvm and then create PR with mongodb-tests with @disabled. WDYT? edited |
I vote for adding the tests to the existing JVM module https://github.com/apache/camel-quarkus/tree/master/extensions-jvm/debezium-mongodb/integration-test |
I see added value with these approach. My only concern is about the fact, that all debezium integration tests are in one module and they are using common code (abstract parents). |
Oh, I see. OK, let's add them to the common Debezium test module and let's not create the native test class so that they run only in the JVM mode? |
ok, sound good. I'll prepare it |
I've started to refactor of mongodb test for jvm only. I discovered that mongodb tests are not complete in my branch (I've had probably discovered that extension was blocked before finishing them) - I'll finish them. |
After investigation it seems that it is not possible to have working jvm tests for debezium mongodb. Here are reasons:
Moreover current debezium mongodb extension does not work in JVM, because it uses newer mongodb driver. @ppalaga What do you think? I'd suggest to wait with completing extension to release of |
It would be nice to check that Debezium master (or whichever branch they are going to release their next 1.4.x from) works for us. If so, let's wait for DBZ 1.4. WDYT? |
I'll try to build some debezium-1.4.snapshot and prepare extension to the branch. In time debezium 1.4 is out, it should be enough to change version in pom and whole extension should be ready. |
We should bump the Debezium version on the Camel side too. Which may actually be a prerequisite to getting this working. I remember in the past we had issues where code was compiled against the Mongo 3.x drivers but 4.x was used at runtime. |
Yes, upgrade of debezium in camel sounds like a correct step. I'll create jira ticket for it and link here. |
I'm trying to prepare JVM tests for debezium-mongodb. But I've found a problem in debezium-connector, which prevents me to finish test using test container (and therefore random port). I've reported issue as https://issues.redhat.com/browse/DBZ-2831. After the fix, I'll continue with preparation of tests using 1.4.0-SNAPSOT. |
Thanks @JiriOndrusek, DBZ-2831 being an issue with quite a serious impact, could you please file a proxy issue on our side too? |
Ok, issue is created - #2060 |
@ppalaga I've created jvm only test in extension-jvm/integration-test in my repo - https://github.com/JiriOndrusek/camel-quarkus/tree/debezium-mongodb-test-jvm-attempt-2 Test is using 1.4.0-SNAPSHOT of debezium-connector - it can not be merged as a part of jvm component so far. If mongodb container's exposed port is set to 27017 (default one) - code , test is successful. I'll look into an option to make it work with 1.3.0-final version of debezium-connector to be able to marge it into git... |
Do not hesitate to give up if it turns out to be too much work. DBZ 1.4.x might come soon enough. |
No description provided.
The text was updated successfully, but these errors were encountered: