Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe Camel's Lifecycle events #1399

Closed
lburgazzoli opened this issue Jun 21, 2020 · 6 comments · Fixed by #1404
Closed

Observe Camel's Lifecycle events #1399

lburgazzoli opened this issue Jun 21, 2020 · 6 comments · Fixed by #1404
Assignees
Milestone

Comments

@lburgazzoli
Copy link
Contributor

No description provided.

@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Jun 21, 2020

There's some overlap between life-cycle and management events:

@jamesnetherton @davsclaus wonder if we should limit life-cycle events to onComponent (add/remove) and onEndpoint (add/remove) and wrap them as custom CamelEvent

@lburgazzoli lburgazzoli self-assigned this Jun 21, 2020
@lburgazzoli lburgazzoli added this to the 1.0.0-CR3 milestone Jun 21, 2020
lburgazzoli added a commit to lburgazzoli/apache-camel-quarkus that referenced this issue Jun 22, 2020
@lburgazzoli
Copy link
Contributor Author

@jamesnetherton @davsclaus a possible implementation proposed as #1404

@davsclaus
Copy link
Contributor

Okay so if we only listen for component add/remove endpoint add/remove is there a special reason for this? Just wonder

@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Jun 22, 2020

I was thinking about have just a single set of events, as example you can listen for Context start event with both a life-cycle callback and with a management event so there's some duplication and I didn't want to expose both to avoid confusion.

It relates to: https://issues.apache.org/jira/browse/CAMEL-11566

lburgazzoli added a commit to lburgazzoli/apache-camel-quarkus that referenced this issue Jun 22, 2020
@lburgazzoli
Copy link
Contributor Author

@davsclaus added the missing non overlapping events

@davsclaus
Copy link
Contributor

Ah okay, so you wanted to present this to the camel-quarkus end users as a uniform api using standard java events. So you dont need to choose when to use lifecycle vs events.

Yeah ideally events should be for end users, and lifecycle for component developers where you need some special integration (spi interface).

But historically then there was only lifecycle in the start of Camel and events was added later, that was a bit tied to jmx events in the start.

However would likely be good to make end users go for events in camel-core over lifecycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants