Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http related tests rely on external service that may sometimes be down #1538

Closed
lburgazzoli opened this issue Aug 18, 2020 · 9 comments
Closed
Assignees
Milestone

Comments

@lburgazzoli
Copy link
Contributor

https://restcountries.eu/rest/v2/alpha/cz is used by http tests but it may be down (as now) and break the tests

@ppalaga
Copy link
Contributor

ppalaga commented Aug 18, 2020

Time to fix restcountries?

@lburgazzoli
Copy link
Contributor Author

wonder if we should use mockserver module

@oscerd
Copy link
Contributor

oscerd commented Aug 18, 2020

That project is mostly dead, there is a guy working on a fork of the apilayer restcountries API and he is providing a new url with the service up and running

@oscerd
Copy link
Contributor

oscerd commented Aug 18, 2020

@jamesnetherton
Copy link
Contributor

wonder if we should use mockserver module

Or just locally stub out whatever endpoint(s) we need with a JAX-RS resource class.

@lburgazzoli
Copy link
Contributor Author

I think the only reason we use restcountries is because of the ssl

@lburgazzoli
Copy link
Contributor Author

I don't know how simple it is to have an ssl and a non ssl endpoint in quarkus

@lburgazzoli
Copy link
Contributor Author

I'm switching to the restcountries.com/v2/alpha/cz for the moment, then we need a better solution

@ppalaga
Copy link
Contributor

ppalaga commented Aug 18, 2020

Yeah, SSL was the main motivation for using restcountries

lburgazzoli added a commit that referenced this issue Aug 19, 2020
lburgazzoli added a commit to lburgazzoli/apache-camel-quarkus that referenced this issue Aug 19, 2020
lburgazzoli added a commit that referenced this issue Aug 19, 2020
@jamesnetherton jamesnetherton self-assigned this Sep 7, 2020
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Sep 7, 2020
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Sep 7, 2020
@ppalaga ppalaga closed this as completed in 91076b4 Sep 7, 2020
@jamesnetherton jamesnetherton added this to the 1.1.0 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants