Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowContextMapAll requires template engines to have reflective access to camel core classess #1807

Closed
jamesnetherton opened this issue Sep 18, 2020 · 1 comment · Fixed by #1855
Assignees
Milestone

Comments

@jamesnetherton
Copy link
Contributor

Thinking a bit more about this comment.

We probably have a general issue with all of the templating component extensions (qute, mustache, mvel, velocity etc) where the template engine may need reflective access to complex objects like Exchange, Message or CamelContext. E.g as described here when allowContextMapAll is enabled.

I don't think we have much (or any) test coverage for this, so we haven't noticed any issues thus far.

We could:

  • Add a general purpose support extension, that would contain a BuildStep to configure reflection for these classes. Then the various extensions could depend on it.

  • Not offer any OOTB support for allowContextMapAll in native mode, and advise folks to keep things simple by only referencing the message body, headers & properties in templates

  • Similar to the above but force users to manually do the reflective class configuration for the necessary bits.

@davsclaus
Copy link
Contributor

allowContextMapAll is a security vulnerabilty fix, so I am fine with no support for setting = true in camel-quarkus native mode or even jvm mode

@jamesnetherton jamesnetherton self-assigned this Sep 23, 2020
@jamesnetherton jamesnetherton added this to the 1.2.0 milestone Sep 23, 2020
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Sep 30, 2020
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Sep 30, 2020
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants