Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is not provided #1860

Closed
ppalaga opened this issue Oct 1, 2020 · 4 comments
Closed

Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is not provided #1860

ppalaga opened this issue Oct 1, 2020 · 4 comments
Assignees
@zbendhiba
Milestone
1.3.0

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Oct 1, 2020

If GOOGLE_GEOCODER_API_KEY is not provided, the test should run against a mock API, something like we do with Telegram and elsewhere. If a mock testcontainer is available we should use it. Perhaps a change is needed in Camel to make the API base URL configurable (like in Telegram).
@ppalaga ppalaga mentioned this issue Oct 1, 2020
Merged
@zbendhiba
Copy link
Contributor

Can you assign this one to me ?

@zbendhiba
Copy link
Contributor

impossible because the URI is hard-coded inside the GeocodingApi used by Camel

@zbendhiba
Copy link
Contributor

related to https://issues.apache.org/jira/browse/CAMEL-15632

zbendhiba added a commit to zbendhiba/camel-quarkus that referenced this issue Oct 7, 2020
@zbendhiba
Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is…
a694a73 
… not provided fixes apache#1860
zbendhiba added a commit to zbendhiba/camel-quarkus that referenced this issue Oct 8, 2020
@zbendhiba
Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is…
d8512fd 
… not provided fixes apache#1860
@zbendhiba zbendhiba mentioned this issue Oct 8, 2020
Merged
zbendhiba added a commit to zbendhiba/camel-quarkus that referenced this issue Oct 8, 2020
@zbendhiba
Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is…
f363035 
… not provided fixes apache#1860
jamesnetherton pushed a commit that referenced this issue Oct 8, 2020
@zbendhiba @jamesnetherton
Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is…
8e644d2 
… not provided fixes #1860
jamesnetherton pushed a commit that referenced this issue Oct 12, 2020
@zbendhiba @jamesnetherton
Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is…
3b7ae6e 
… not provided fixes #1860
github-actions bot pushed a commit that referenced this issue Oct 13, 2020
@zbendhiba @github-actions
Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is…
5670648 
… not provided fixes #1860
jamesnetherton pushed a commit that referenced this issue Oct 14, 2020
@zbendhiba @jamesnetherton
Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is…
1fcf085 
… not provided fixes #1860
jamesnetherton pushed a commit that referenced this issue Oct 15, 2020
@zbendhiba @jamesnetherton
Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is…
ed1eb3f 
… not provided fixes #1860
ppalaga pushed a commit that referenced this issue Oct 16, 2020
@zbendhiba @ppalaga
Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is…
6649cc3 
… not provided fixes #1860
@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 17, 2020

Fixed in 1.3.0 via 6649cc3

@ppalaga ppalaga closed this as completed Oct 17, 2020
@ppalaga ppalaga added this to the 1.3.0 milestone Oct 17, 2020
ppalaga pushed a commit that referenced this issue Oct 17, 2020
@zbendhiba @ppalaga
Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is…
104575e 
… not provided fixes #1860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zbendhiba zbendhiba

Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@ppalaga @zbendhiba