Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freemarker native support #223

Closed
carlosthe19916 opened this issue Oct 3, 2019 · 15 comments · Fixed by #2184
Closed

Freemarker native support #223

carlosthe19916 opened this issue Oct 3, 2019 · 15 comments · Fixed by #2184

Comments

@carlosthe19916
Copy link

No description provided.

@carlosthe19916 carlosthe19916 changed the title support for camel-freemarke support for camel-freemarker Oct 3, 2019
@ppalaga
Copy link
Contributor

ppalaga commented Oct 3, 2019

@carlosthe19916 are you working on this one?

@carlosthe19916
Copy link
Author

@ppalaga I'd like to contribute in some way and I'm really curious about using Quakus and Freemarker in personal projects. I'm not sure if I will achieve the goal of adding a new extension but I'd like to give it a try.

@ppalaga
Copy link
Contributor

ppalaga commented Oct 3, 2019

@carlosthe19916 new extensions are welcome! You may find https://camel.apache.org/camel-quarkus/latest/contributor-guide.html useful.

@ppalaga
Copy link
Contributor

ppalaga commented Feb 27, 2020

@carlosthe19916 are you still interested to look into this?

@carlosthe19916
Copy link
Author

@ppalaga My apologies for not updating this Issue before. I'm still interested in this for sure. Thb, I've created my very basic version of Native Freemarker extension here https://github.com/project-openubl/xml-builder/blob/master/extensions/freemarker/deployment/src/main/java/org/openublpe/quarkus/freemarker/deployment/FreemarkerProcessor.java. I'm not sure how much different could be using camel

@carlosthe19916
Copy link
Author

@ppalaga Here I've just created a very basic first draft for the camel-freemarker extension. But I still need to enhance the code https://github.com/carlosthe19916/camel-quarkus/tree/camel-freemarker

@ppalaga
Copy link
Contributor

ppalaga commented Feb 28, 2020

@carlosthe19916 tanks for the effort! If you want an early feedback, please feel free to send a draft pull request https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ppalaga ppalaga changed the title support for camel-freemarker Freemarker native support Sep 8, 2020
@ppalaga ppalaga added the native label Sep 8, 2020
@ppalaga
Copy link
Contributor

ppalaga commented Sep 8, 2020

A JVM-only extension (without a proper test) is underway.

@vsevel
Copy link

vsevel commented Sep 16, 2020

is there any plan to offer freemarker as a quarkus extension (independently from camel), and get the camel-quarkus to depend on it?
this would be useful for people interested in quarkus+freemarker, and not necessarily in camel.

@ppalaga
Copy link
Contributor

ppalaga commented Sep 16, 2020

is there any plan to offer freemarker as a quarkus extension (independently from camel), and get the camel-quarkus to depend on it?

This would indeed make sense and we'd be eventually ready to depend on such a generic Freemarker extension. I think the Freemarker project would be the best place for this effort. Any help to drive that effort is welcome.

@vsevel
Copy link

vsevel commented Sep 16, 2020

I think the Freemarker project would be the best place for this effort.

or the quarkus project itself. that is where almost all of the extensions are developed.

@ppalaga
Copy link
Contributor

ppalaga commented Sep 16, 2020

I think the Freemarker project would be the best place for this effort.

or the quarkus project itself. that is where almost all of the extensions are developed.

A Quarkus dependency would be easier maintain for us. Anybody please feel free to propose it in Quarkus or in Freemarker.

@vsevel
Copy link

vsevel commented Sep 17, 2020

A Quarkus dependency would be easier maintain for us. Anybody please feel free to propose it in Quarkus or in Freemarker.

@ppalaga we have a need for a freemarker extension on our project. if time and energy we may develop the extension, starting from https://github.com/carlosthe19916/camel-quarkus/tree/camel-freemarker, then we will see if the quarkus team is interested. I am not sure yet we have this capacity, but it is definitely a possibility.

@zhfeng
Copy link
Contributor

zhfeng commented Oct 10, 2020

@vsevel so we can leverage the https://github.com/quarkiverse/quarkiverse-freemarker now ?

@vsevel
Copy link

vsevel commented Oct 10, 2020

@zhfeng 0.0.4 should provide a good first version to start playing with. it is the bare minimum. from this original issue, I just did not migrate over the filtering capabilities (include/exclude).
for now I included the doc in the project itself https://github.com/quarkiverse/quarkiverse-freemarker/blob/master/doc/freemarker.adoc, waiting for quarkusio/quarkus#12526
I will have minimal bandwidth to make evolutions, but PR are welcome.

@ppalaga ppalaga self-assigned this Nov 20, 2020
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Feb 1, 2021
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Feb 1, 2021
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Feb 1, 2021
@jamesnetherton jamesnetherton added this to the 1.7.0 milestone Feb 3, 2021
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Feb 17, 2021
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Feb 18, 2021
@ppalaga ppalaga removed this from the 1.7.0 milestone Feb 19, 2021
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Feb 23, 2021
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Feb 23, 2021
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Feb 23, 2021
ppalaga added a commit that referenced this issue Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Component Extensions
  
Awaiting triage
Development

Successfully merging a pull request may close this issue.

6 participants