Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Camel 3.10] jsonpath: Getting rid of json-smart as explicit and transitive dependency #2435

Closed
zbendhiba opened this issue Apr 1, 2021 · 8 comments · Fixed by #2669
Closed
Assignees
Milestone

Comments

@zbendhiba
Copy link
Contributor

zbendhiba commented Apr 1, 2021

The JIRA from camel : CAMEL-16375
The json-smart has been removed from camel-jsonpath see commit : b59a96ddf1ba647b979f937f5bd956bba32173ee

These classes are not compiling anymore : JSONValueSubstitution and JSONWriterSubstitution

@ppalaga ppalaga changed the title jsonpath: json-smart removed from camel-jsonpath [Camel 3.10] jsonpath: json-smart removed from camel-jsonpath Apr 1, 2021
@zbendhiba zbendhiba self-assigned this Apr 7, 2021
@zbendhiba
Copy link
Contributor Author

temporarly reintroduced json-smart to make CI build work.
It need to be fixed for 3.10

@zbendhiba zbendhiba added this to the 1.9.0 milestone Apr 29, 2021
@zbendhiba zbendhiba changed the title [Camel 3.10] jsonpath: json-smart removed from camel-jsonpath [Camel 3.10] jsonpath: Getting rid of json-smart as explicit and transitive dependency May 18, 2021
@ppalaga ppalaga modified the milestones: 1.9.0, 2.0.0 May 24, 2021
@zbendhiba
Copy link
Contributor Author

since Graalvm needs json-smart at build time, move the version to 2.4.7, that fixes the CVE

zbendhiba added a commit to zbendhiba/camel-quarkus that referenced this issue May 25, 2021
jamesnetherton pushed a commit that referenced this issue May 26, 2021
@jamesnetherton
Copy link
Contributor

Reopening as per #2669 (comment).

@zbendhiba
Copy link
Contributor Author

@jamesnetherton I still don't know how to substitute those ValueNode and JsonNode classes.
Is there a way to delete imported classes with substitution ? I try to substitute the methods, but I get those kind of errors in compilation
Error: Class initialization of com.jayway.jsonpath.internal.filter.ValueNodes$JsonNode failed. Use the option --initialize-at-run-time=com.jayway.jsonpath.internal.filter.ValueNodes$JsonNode to explicitly request delayed initialization of this class. Original exception that caused the problem: java.lang.NoClassDefFoundError: net/minidev/json/parser/ParseException

@jamesnetherton
Copy link
Contributor

@zbendhiba can you share a branch with your WIP so I can take a look?

@zbendhiba
Copy link
Contributor Author

@jamesnetherton
Copy link
Contributor

@zbendhiba I took a look and I cant see an easy solution.

Sorry for wasting your time working on it. I really thought it'd be simple(ish) to cut out json-smart. I guess for now we're stuck having to include the dependency.

@zbendhiba
Copy link
Contributor Author

So I can close this one then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants