Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quarkus 2.0] Consider following the way how Quarkus handles Avro schemas #2513

Closed
ppalaga opened this issue Apr 26, 2021 · 5 comments
Closed
Assignees
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Apr 26, 2021

With quarkusio/quarkus#16169 and a couple of other related PRs Quarkus introduced a new approach for compiling Avro schemas. They are now compiled using generate-code and generate-code-tests mojos of quarkus-maven-plugin. I wonder whether we should recommend the same to our end users and maybe deprecate our @BuildTimeAvroDataFormat annotation?

@ppalaga
Copy link
Contributor Author

ppalaga commented Apr 26, 2021

WDYT @aldettinger ?

@ppalaga
Copy link
Contributor Author

ppalaga commented Apr 26, 2021

I guess we should at least document the new option.

@aldettinger
Copy link
Contributor

Indeed, I think deprecating @BuildTimeAvroDataFormat + documenting the new option is good.

@ppalaga
Copy link
Contributor Author

ppalaga commented Apr 26, 2021

Thanks, I think we can do this once we have Quarkus 2.0.x in our main branch.

@ppalaga ppalaga changed the title Consider following the way how Quarkus handles Avro schemas [Quarkus 2.0] Consider following the way how Quarkus handles Avro schemas May 19, 2021
@jamesnetherton jamesnetherton added this to the 2.0.0 milestone Jun 8, 2021
@jamesnetherton
Copy link
Contributor

I moved this to the 2.0.0 milestone as I think it'd be good to get this done.

Would also be good if we could cover the different schema types avdl, avpr & avsc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants