Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build time property to register classes for reflection #253

Closed
lburgazzoli opened this issue Oct 10, 2019 · 5 comments · Fixed by #987
Closed

Build time property to register classes for reflection #253

lburgazzoli opened this issue Oct 10, 2019 · 5 comments · Fixed by #987
Assignees
Labels
question Further information is requested
Milestone

Comments

@lburgazzoli
Copy link
Contributor

Users may need to register additional classes for reflection i.e. provided by 3th party artefacts while writing routes and as today they have the following options:

  • write an extension
  • create a reflection configuration file as described here

Both the options are possible but wondering if we could further ease the process for simple cases by providing a build time property to list classes that need to be registered for reflection.

@lburgazzoli lburgazzoli added the question Further information is requested label Oct 10, 2019
@ppalaga
Copy link
Contributor

ppalaga commented Oct 10, 2019

+1 That will surely be helpful when investigating issues.

Does this not belong to Quarkus itself actually?

@lburgazzoli
Copy link
Contributor Author

I know that they are thinking about something but not sure about if they will actually make it, when and how.

I'll investigate a little bit and eventually I'll implement an interim solution.

@ppalaga
Copy link
Contributor

ppalaga commented Mar 26, 2020

@RegisterForReflection can actually be used also to register third party classes https://github.com/quarkusio/quarkus/blob/master/core/runtime/src/main/java/io/quarkus/runtime/annotations/RegisterForReflection.java#L25-L32

I'd say that's enough and we do not need to do anything on the Camel Quarkus side. WDYT, @lburgazzoli ?

@lburgazzoli
Copy link
Contributor Author

I'm aware of that class however it may be more practical if we have a configuration property as i.e. it would be much more practical in camel-k so a user do not nee to write any java code and we don't need to store any additional java file in the CR just for the need to list classes that need to be registered for reflection

@ppalaga
Copy link
Contributor

ppalaga commented Mar 26, 2020

it would be much more practical in camel-k

I suspected you are going to come with something like this :). Moving quarkus.camel.resources.* to quarkus.camel.native.resources.* and putting this new opt. there seems like optimal variant. Would you please upvote #983 if you think so?

@ppalaga ppalaga self-assigned this Mar 26, 2020
@ppalaga ppalaga changed the title Build time property to list additional classes for reflection Build time property to register classes for reflection Mar 26, 2020
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants