Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing use cases into MongoDb test coverage #2715

Closed
JiriOndrusek opened this issue Jun 3, 2021 · 2 comments · Fixed by #2716
Closed

Add missing use cases into MongoDb test coverage #2715

JiriOndrusek opened this issue Jun 3, 2021 · 2 comments · Fixed by #2716
Assignees
@JiriOndrusek
Milestone
2.0.0-M2

Comments

@JiriOndrusek
Copy link
Contributor

Follows #2622.

  • DocumentList outputType is not tested.
  • Configuring via application.properties is not tested .
  • Mongo version is hardcoded for 4.0, it would be better to use the latest one, which is 4.4
@JiriOndrusek JiriOndrusek self-assigned this Jun 3, 2021
@jamesnetherton
Copy link
Contributor

  • Configuring via application.properties is not tested .

Do we really need that? MongoDbTestResource sets the configuration properties for the application under test, which should be good enough.

@JiriOndrusek
Copy link
Contributor Author

JiriOndrusek commented Jun 3, 2021 •
edited

I'd like to add another client using property quarkus.mongodb.<name>.connection-string because it is described in doc. Current test is using quarkus.mongodb.<name>.hosts. May be I should modify formulation of this issue, to be clear.

EDIT:
Or probably I just change current test to use connection-string instead of hosts to cover doc.

JiriOndrusek added a commit to JiriOndrusek/camel-quarkus that referenced this issue Jun 3, 2021
@JiriOndrusek
Add missing use cases into MongoDb test coverage apache#2715
d5f75fb
JiriOndrusek added a commit to JiriOndrusek/camel-quarkus that referenced this issue Jun 3, 2021
@JiriOndrusek
Add missing use cases into MongoDb test coverage apache#2715
129f8ac
JiriOndrusek added a commit to JiriOndrusek/camel-quarkus that referenced this issue Jun 3, 2021
@JiriOndrusek
Add missing use cases into MongoDb test coverage apache#2715
10e40c2
@JiriOndrusek JiriOndrusek mentioned this issue Jun 3, 2021
Merged
jamesnetherton pushed a commit that referenced this issue Jun 4, 2021
@JiriOndrusek @jamesnetherton
Add missing use cases into MongoDb test coverage #2715
7f56177
@ppalaga ppalaga added this to the 2.0.0-M2 milestone Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiriOndrusek JiriOndrusek

Labels
None yet
Projects
None yet
Milestone
2.0.0-M2
Development

Successfully merging a pull request may close this issue.

Add missing use cases into MongoDb test coverage #2715 JiriOndrusek/camel-quarkus
3 participants
@ppalaga @jamesnetherton @JiriOndrusek