Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON Jackson jacksonConversionPojo test #2726

Closed
jamesnetherton opened this issue Jun 4, 2021 · 2 comments
Closed

Fix JSON Jackson jacksonConversionPojo test #2726

jamesnetherton opened this issue Jun 4, 2021 · 2 comments
Assignees
@ffang
Labels
test
Milestone
2.0.0

Comments

@jamesnetherton
Copy link
Contributor

Seem comment here:

camel-quarkus/integration-tests/dataformats-json/src/main/java/org/apache/camel/quarkus/component/dataformats/jackson/json/JacksonJsonResource.java

Lines 515 to 520 in f65f3b9

/*
* somehow jaxb annotation @XmlAttribute(name = "customer_name") can't be taken into accout so the
* following asserts failed, need to investigate more
* assertEquals("{\"id\":0,\"partName\":\"Camel\",\"amount\":1,\"customer_name\":\"Acme\"}",
* json);
*/

@jamesnetherton jamesnetherton changed the title Fix JSON Jackson conversion-pojo test Fix JSON Jackson jacksonConversionPojo test Jun 4, 2021
@ffang
Copy link
Contributor

ffang commented Jun 7, 2021

Hi @jamesnetherton,

FYI, I believe this has been fixed by #2677 already.
Sorry, I forget to re-enable this test. I will send a PR to re-enable this test soon.

Best Regards
Freeman

ffang added a commit to ffang/camel-quarkus that referenced this issue Jun 7, 2021
@ffang
Fix JSON Jackson jacksonConversionPojo test apache#2726
e5bb191
@ffang ffang self-assigned this Jun 8, 2021
@ppalaga
Copy link
Contributor

ppalaga commented Jun 14, 2021

Any update, @ffang ?

ffang added a commit to ffang/camel-quarkus that referenced this issue Jun 14, 2021
@ffang
apache#2726 address feedback
f934589
ffang added a commit to ffang/camel-quarkus that referenced this issue Jun 15, 2021
@ffang
apache#2726 revert unintentional changes for this issue
5b0d54f
ffang added a commit to ffang/camel-quarkus that referenced this issue Jun 15, 2021
@ffang
Fix JSON Jackson jacksonConversionPojo test-addressed feedback apache…
7510631 
…#2726
ffang added a commit to ffang/camel-quarkus that referenced this issue Jun 15, 2021
@ffang
Fix JSON Jackson jacksonConversionPojo test-addressed feedback apache…
bce435d 
…#2726

(cherry picked from commit 7510631)
ffang added a commit to ffang/camel-quarkus that referenced this issue Jun 15, 2021
@ffang
Fix JSON Jackson jacksonConversionPojo test-addressed feedback apache…
ef5705b 
…#2726

(cherry picked from commit 7510631)

address feedback 2726
ffang added a commit to ffang/camel-quarkus that referenced this issue Jun 16, 2021
@ffang
using injection for the field in testcase apache#2726
f7e25b0
ffang added a commit to ffang/camel-quarkus that referenced this issue Jun 16, 2021
@ffang
Fix JSON Jackson jacksonConversionPojo test-addressed feedback apache…
140fcb1 
…#2726

(cherry picked from commit 7510631)

Fix JSON Jackson jacksonConversionPojo test-squash apache#2726
ffang added a commit to ffang/camel-quarkus that referenced this issue Jun 16, 2021
@ffang
Fix JSON Jackson jacksonConversionPojo test-squashed apache#2726
3f241e6
ffang added a commit that referenced this issue Jun 16, 2021
@ffang
Fix JSON Jackson jacksonConversionPojo test-squashed #2726 (#2790)
bb26ab6
@ffang ffang closed this as completed Jun 16, 2021
ffang added a commit to ffang/camel-quarkus that referenced this issue Jun 17, 2021
@ffang
Fix JSON Jackson jacksonConversionPojo test-squashed apache#2726 (apa…
bdad147 
…che#2790)

(cherry picked from commit bb26ab6)
jamesnetherton pushed a commit to jboss-fuse/camel-quarkus that referenced this issue Jun 18, 2021
@ffang @jamesnetherton
Fix JSON Jackson jacksonConversionPojo test-squashed apache#2726 (apa…
a1f080b 
…che#2790)

(cherry picked from commit bb26ab6)
@ppalaga ppalaga added this to the 2.0.0 milestone Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffang ffang

Labels
test
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@ffang @ppalaga @jamesnetherton