Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to test HL7 extension with multiple HAPI implementations #2744

Closed
jamesnetherton opened this issue Jun 8, 2021 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@jamesnetherton
Copy link
Contributor

I deliberately restricted the tests to use only a single HAPI impl as adding multiple libs slows down the native build, as a lot of stuff is required to be registered for reflection.

It could be beneficial to be able to test with multiple HAPI dependencies on the classpath, so we could perhaps have that under a maven / Quarkus test profile which could be activated manually if required.

@ppalaga
Copy link
Contributor

ppalaga commented Jun 8, 2021

I wonder whether the component could not be split per implementation (or in some other way) either in Camel or in Camel Quarkus?

@jamesnetherton
Copy link
Contributor Author

I wonder whether the component could not be split per implementation (or in some other way) either in Camel or in Camel Quarkus?

Not sure that's feasible / desirable given that there are so many HAPI versions and new ones will eventually get added.

In reality, it could be that users will never have multiple HAPI impls on the classpath. But since it's possible, we should probably test it...

@jamesnetherton jamesnetherton self-assigned this Jun 15, 2021
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Aug 25, 2021
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Aug 25, 2021
@ppalaga ppalaga added this to the 2.2.0 milestone Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants