Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-negate the names #285

Closed
ppalaga opened this issue Oct 18, 2019 · 1 comment
Closed

Un-negate the names #285

ppalaga opened this issue Oct 18, 2019 · 1 comment
Assignees

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Oct 18, 2019

We have several config options which start with disable as well as some similarly named classes. Using negation in names makes them harder to understand, mainly when get negated once again in an expression like the following.

@BuildStep(onlyIfNot = Flags.MainDisabled.class)

I propose to rename all those to something like quarkus.camel.main-enabled and refactor all as needed. We should do this before 1.0.0.

Please assign to me.

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 19, 2019

This would be easy to do and I am ready to do that. If somebody wants to veto the proposal please do so sooner rather than later so that I do not waste my time.

ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant