Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Camel's async processor in platform-http #299

Closed
ppalaga opened this issue Oct 21, 2019 · 2 comments
Closed

Use Camel's async processor in platform-http #299

ppalaga opened this issue Oct 21, 2019 · 2 comments
Assignees
@ppalaga
Milestone
1.0.0

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Oct 21, 2019

We currently always add our handler as non-blocking https://github.com/apache/camel-quarkus/blob/master/extensions/platform-http/runtime/src/main/java/org/apache/camel/quarkus/component/platform/http/runtime/QuarkusPlatformHttpConsumer.java#L95-L108

Shouldn't we have an URI parameter for the user to decide whether io.vertx.ext.web.Route.blockingHandler() should be called instead of io.vertx.ext.web.Route.handler()?
@lburgazzoli
Copy link
Contributor

Maybe we need to use camel's async processor and always use the non blocking one, something like: https://github.com/apache/camel-k-runtime/blob/master/camel-knative/camel-knative-http/src/main/java/org/apache/camel/component/knative/http/KnativeHttpConsumer.java#L85-L137

@ppalaga ppalaga changed the title Question: should platform-http have a "blocking" option? Use Camel's async processor in platform-http Oct 21, 2019
@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 21, 2019

Plz assign to me.

@lburgazzoli lburgazzoli added this to the quarkus 1.0.0 milestone Oct 21, 2019
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Oct 29, 2019
@ppalaga
Fix apache#299 Use Camel's async processor in platform-http
d61ddac
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Oct 30, 2019
@ppalaga
Fix apache#299 Use Camel's async processor in platform-http
bf76e48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppalaga ppalaga

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@ppalaga @lburgazzoli