Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve native support for org.apache.http.impl.client.BasicAuthCache #3079

Closed
jamesnetherton opened this issue Sep 8, 2021 · 7 comments
Closed
Assignees
Milestone

Comments

@jamesnetherton
Copy link
Contributor

BasicAuthCache attempts to do object serialization, so we need to handle that.

https://github.com/apache/httpcomponents-client/blob/rel/v4.5.13/httpclient/src/main/java/org/apache/http/impl/client/BasicAuthCache.java#L97-L146

Usage of the class is mentioned in the camel-http docs, so we should try to get it working properly in native mode.

@jamesnetherton jamesnetherton added this to the 2.3.0 milestone Sep 8, 2021
@jamesnetherton jamesnetherton changed the title Improve native support for org.apache.http.impl.client.BasicAuthCache. Improve native support for org.apache.http.impl.client.BasicAuthCache Sep 8, 2021
@aldettinger
Copy link
Contributor

aldettinger commented Sep 8, 2021

In couchdb, we ended up doing a substitution:
https://github.com/apache/camel-quarkus/blob/main/extensions/couchdb/runtime/src/main/java/org/apache/camel/quarkus/couchdb/BasicAuthCacheAlias.java

Whatever the fix is, it's worth considering to align accross camel-quarkus.

@aldettinger
Copy link
Contributor

There is also a comment in httpclient jira stating that serialization is not a hard requirement for BasicAuthCache.

@jamesnetherton
Copy link
Contributor Author

In couchdb, we ended up doing a substitution:

Then that fix probably belongs in camel-quarkus-support-httpclient.

@aldettinger
Copy link
Contributor

Indeed, and maybe it's just a matter of configuring the serialization of AuthSchemes now that camel-quarkus supports serialization.

@jamesnetherton jamesnetherton self-assigned this Sep 9, 2021
@ppalaga
Copy link
Contributor

ppalaga commented Sep 9, 2021

I wonder why this has not been popping up in our HttpTest.basicAuth() test?

@aldettinger
Copy link
Contributor

I was thinking maybe it's used only for preemptive auth but was not able to prove it with a test.

@jamesnetherton
Copy link
Contributor Author

I wonder why this has not been popping up in our HttpTest.basicAuth() test?

Because we don't explicity configure the BasicAuthCache in the tests and I guess the Camel component does not do so either.

jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Sep 15, 2021
ppalaga pushed a commit to ppalaga/camel-quarkus that referenced this issue Sep 19, 2021
ppalaga pushed a commit to ppalaga/camel-quarkus that referenced this issue Sep 19, 2021
ppalaga pushed a commit to ppalaga/camel-quarkus that referenced this issue Sep 19, 2021
ppalaga pushed a commit to jboss-fuse/camel-quarkus that referenced this issue Sep 20, 2021
VratislavHais pushed a commit to VratislavHais/camel-quarkus that referenced this issue Sep 21, 2021
ppalaga pushed a commit to ppalaga/camel-quarkus that referenced this issue Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants