Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multipart/form-data in platform-http extension #308

Closed
ppalaga opened this issue Oct 22, 2019 · 1 comment
Closed

Support multipart/form-data in platform-http extension #308

ppalaga opened this issue Oct 22, 2019 · 1 comment

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Oct 22, 2019

I assume we definitely want to support this, for the platform-http to be on par with the older HTTP components.

The question is how to implement that. The older components use AttachmentMessage from camel-attachments to store the uploaded files. camel-attachments depends on javax.activation.

(a) The "easy" solution: pull camel-attachments and javax.activation as dependencies, and do not care for the increase of the app size caused by that.

(b) The "optional" solution: provide some no-op handling of file uploads by default that does not depend on camel-attachments and javax.activation. Handle the uploads properly via camel-attachments (wrapped in an extension) and javax.activation only if the user adds them as deps.

(c) ?

Is the work associated with (b) worth the benefits it might bring?

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 22, 2019

I implemented the "easy" solution and it adds 560 kB to the master baseline in the platform-http itest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant