Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move infinispan integration-tests out of core #31

Closed
lburgazzoli opened this issue Jul 3, 2019 · 6 comments
Closed

Move infinispan integration-tests out of core #31

lburgazzoli opened this issue Jul 3, 2019 · 6 comments
Assignees

Comments

@lburgazzoli
Copy link
Contributor

No description provided.

@lburgazzoli lburgazzoli changed the title Move infinispan tests out fo core Move infinispan integration-tests out fo core Jul 3, 2019
@ppalaga
Copy link
Contributor

ppalaga commented Jul 3, 2019

I clearly see the benefit of testing separately and having a separate project for each component that can serve as a basic quickstart.

OTOH, each separate integration test module will prolong the build by ~2 minutes. Do we really want that? My personal limit for CI is ~40mins. Now we are at ~28mins, IIRC. So we can basically do this, but maybe for the future, we should think of some sort of policy that would keep the CI run times reasonable. Testing several extensions in one IT module is actually one possible solution, so once again the question, is it really worth splitting now?

@oscerd
Copy link
Contributor

oscerd commented Jul 3, 2019

I think a reasonable time for CI can be more than 40 minutes.

@ppalaga
Copy link
Contributor

ppalaga commented Jul 3, 2019

I think a reasonable time for CI can be more than 40 minutes.

I wonder what is your upper bound for a CI job that verifies pull requests?

@oscerd
Copy link
Contributor

oscerd commented Jul 3, 2019

it depends on the dimension of a project: in camel we cannot do a full build because it's too much stuff for a single PR. I think up to 90 minutes is reasonable.

@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Jul 3, 2019

I clearly see the benefit of testing separately and having a separate project for each component that can serve as a basic quickstart.

OTOH, each separate integration test module will prolong the build by ~2 minutes. Do we really want that? My personal limit for CI is ~40mins. Now we are at ~28mins, IIRC. So we can basically do this, but maybe for the future, we should think of some sort of policy that would keep the CI run times reasonable. Testing several extensions in one IT module is actually one possible solution, so once again the question, is it really worth splitting now?

There's no rush to move them out of core now but we should provide more tests for every extensions to aver better coverage for native compiled code (as today the tests we have for nett4-http and infinispan are the bare minimum).

BTW, nothing is written in stones and we can always rethink our decisions and group modules when it make sense but IMHO, testing component extension inside the core one is just bad.

@ppalaga
Copy link
Contributor

ppalaga commented Jul 3, 2019

Yes, there is no doubt that more coverage is better.

@lburgazzoli lburgazzoli changed the title Move infinispan integration-tests out fo core Move infinispan integration-tests out of core Jul 8, 2019
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Jul 9, 2019
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Jul 9, 2019
@ppalaga ppalaga added this to the No fix/wont't fix milestone Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants