New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move infinispan integration-tests out of core #31
Comments
I clearly see the benefit of testing separately and having a separate project for each component that can serve as a basic quickstart. OTOH, each separate integration test module will prolong the build by ~2 minutes. Do we really want that? My personal limit for CI is ~40mins. Now we are at ~28mins, IIRC. So we can basically do this, but maybe for the future, we should think of some sort of policy that would keep the CI run times reasonable. Testing several extensions in one IT module is actually one possible solution, so once again the question, is it really worth splitting now? |
I think a reasonable time for CI can be more than 40 minutes. |
I wonder what is your upper bound for a CI job that verifies pull requests? |
it depends on the dimension of a project: in camel we cannot do a full build because it's too much stuff for a single PR. I think up to 90 minutes is reasonable. |
There's no rush to move them out of core now but we should provide more tests for every extensions to aver better coverage for native compiled code (as today the tests we have for nett4-http and infinispan are the bare minimum). BTW, nothing is written in stones and we can always rethink our decisions and group modules when it make sense but IMHO, testing component extension inside the core one is just bad. |
Yes, there is no doubt that more coverage is better. |
No description provided.
The text was updated successfully, but these errors were encountered: