Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with the code formatter plugin https://code.revelc.net/formatter-maven-plugin/ #337

Closed
gnodet opened this issue Oct 25, 2019 · 4 comments
Assignees

Comments

@gnodet
Copy link
Contributor

gnodet commented Oct 25, 2019

No description provided.

@ppalaga
Copy link
Contributor

ppalaga commented Oct 25, 2019

It needs Eclipse formatter settings XML file. What would be your strategy to get one? I started using the one from the main Camel repo and it seems to be quite distant from what we currently have in the camel-quarkus repo.

@ppalaga
Copy link
Contributor

ppalaga commented Oct 25, 2019

impsort-maven-plugin would be also nice for sorting the imports.

https://code.revelc.net/impsort-maven-plugin/

@lburgazzoli
Copy link
Contributor

would it be possible to share the same rules with the IDE ? IMH formatting tools to be effective need to be usable straight from the IDE

@ppalaga
Copy link
Contributor

ppalaga commented Oct 25, 2019

The formatter-maven-plugin uses Eclipse JDT under the hood, so it's config file can be directly used in Eclipse. For IntelliJ, IIRC, in the Quarkus ML people mentioned that there is am IJ plugin that supports the Eclipse formatting files.

No idea whether there is some solution for the impsort-maven-plugin. I'd personally would not care, because the imports ordering is quite easy to setup in the IDE manually.

gnodet added a commit to gnodet/camel-quarkus that referenced this issue Nov 4, 2019
gnodet added a commit to gnodet/camel-quarkus that referenced this issue Nov 4, 2019
gnodet added a commit to gnodet/camel-quarkus that referenced this issue Nov 5, 2019
gnodet added a commit to gnodet/camel-quarkus that referenced this issue Nov 5, 2019
@gnodet gnodet closed this as completed in c4fe6a0 Nov 5, 2019
gnodet added a commit that referenced this issue Nov 5, 2019
Use automatic code formatting, fixes #337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants