Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate / remove quarkus.camel.main.enabled configuration property #3446

Closed
jamesnetherton opened this issue Jan 11, 2022 · 0 comments
Closed

Deprecate / remove quarkus.camel.main.enabled configuration property #3446

jamesnetherton opened this issue Jan 11, 2022 · 0 comments
Assignees
@jamesnetherton
Milestone
2.7.0

Comments

@jamesnetherton
Copy link
Contributor

jamesnetherton commented Jan 11, 2022 •
edited
Loading

See Zulip thread discussing the merits of removing quarkus.camel.main.enabled:

https://camel.zulipchat.com/#narrow/stream/257302-camel-quarkus/topic/Disabling.20camel.20main

TL;DR

  • There's additional overhead maintaining logic that runs with main vs non-main
  • Probably nobody is disabling main
  • The original intent & purpose of allowing main vs non-main is now redundant

There's just the question of when we remove & deprecate the feature. I.e deprecate in 2.7 & remove in 2.8. Or deprecate in 2.x and remove in 3.x. Or remove immediately for 2.7.
@jamesnetherton jamesnetherton added this to the 2.7.0 milestone Jan 11, 2022
@jamesnetherton jamesnetherton changed the title Deprecate / remove quarkus.camel.bootstrap.enabled configuration property Deprecate / remove quarkus.camel.main.enabled configuration property Jan 11, 2022
@aldettinger aldettinger mentioned this issue Jan 11, 2022
Open
@jamesnetherton jamesnetherton self-assigned this Jan 11, 2022
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Jan 25, 2022
@jamesnetherton
Remove quarkus.camel.main.enabled configuration property
ec76fe3 
Fixes apache#3446
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Jan 25, 2022
@jamesnetherton
Remove quarkus.camel.main.enabled configuration property
bb28af4 
Fixes apache#3446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesnetherton jamesnetherton

Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
1 participant
@jamesnetherton