-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide aggregated tests for quarkus-platform #413
Comments
I was also thinking of how the platform can maintain our tests in the long term. My idea was to produce some metadata on our side (basically a list of our itest project GAVs) that the platform could leverage to generate/validate the modules in their source tree. I was thinking of adding a mojo to rpkgtests-maven-plugin to implement that. The rpkgtests:rpkgtests mojo could also use the metadata so that the testJars do not need to get configured manually. This would be easier for us (we'd keep working as before, we'd just add a maven module that would generate the metadata). Not sure this would be acceptable for the platform. |
This is implemented now. Updating the tests in the platform is not that a big issue with the new tooling. I also would not say the number of the tests is an issue for them. Their CI runs only in JVM mode. Having said that, I do not see an immediate need to improve anything in this area. |
Now after a couple of Camel Quarkus upgrades in the Platform and after @galderz has detected quite a few issues through our tests there, I'd like to update my standpoint as follows:
(1) quarkus-bom is imported before our BOM and Thus dependencies managed in all those 3rd party BOMs get a higher precedence that the ones managed by us. Given the above I am against bothering with creating any reduced set of tests for the platform and I vote for closing this issue. |
Agreed, but what happens if we do eventually support another 100+ extensions. We potentially have a negative impact on the platform side by adding an ever increasing amount of stuff. |
I'd leave it to the platform to define their limits and complain when we exceed them. |
@ppalaga @jamesnetherton I'd close this issue and think about this issue if/when there will be complains from quarkus, what do you think ? |
Yep - I agree. Let's close. |
The quarkus-platform now includes the same tests as we have here but it does not seems very sustainable in term of maintenance and resources required to validate the quarkus-platform.
We should create some aggregated test that validates multiple components in a single test
The text was updated successfully, but these errors were encountered: