New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #476 List itests in an XML file for the Quarkus platform #482
Conversation
wonder if as future evolution, the xml with the list of the integration-test could be auto generated like all the it with a specific property are included (or excluded) |
bd419b9 fixes the license header problem |
(Not sure you noticed) it is currently autogenerated and there is some file path based filtering there. Is that not enough? https://github.com/apache/camel-quarkus/pull/482/files#diff-e0dff2635520bef5f237973025e0a295R51-R63 |
oh, damn me. didn't notice |
got confused because I saw the generated file also included in the repo, maybe as it is auto generated it should not be checked in |
I prefer to have it in git to be able to check anytime quickly what we export and also to have the history thereof. WDYT? Now fixing the JAXB issue on Java 11. |
in general I'd go for not including auto generated code as It may be another source of conflicts and confusion as people may try to change them manually but it is not a huge issue |
Yes, potential merge conflicts in the XML file would be nice to avoid. The main motivation for me to keep the file in Git for now is that we have some irregularities in the |
ok to test |
@ppalaga I have no objection to keep it now but long term solution would be better to remove it. We may think to move support test extension in a dedicated support folder so main and core and future it tests are just like other tests and we only need to skip indexing the support folder |
What an elegant option! |
Refer to this link for build results (access rights to CI server needed): |
There is no version in the XML list of tests anymore as proposed by @lburgazzoli.
The XML is now deployed directly instead of being deployed in a jar.