Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include the source XSLT files into the application archive #438

Closed
ppalaga opened this issue Nov 19, 2019 · 10 comments
Closed

Do not include the source XSLT files into the application archive #438

ppalaga opened this issue Nov 19, 2019 · 10 comments

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Nov 19, 2019

We compile the XSL template files into translets at build time so there is no point in having them in the archive. Let's exclude them once Quarkus provides means for that. Blocked by quarkusio/quarkus#5576

@lburgazzoli
Copy link
Contributor

I remember either the xls engine or camel try to access the file when the route starts, it is not more the case ?

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 19, 2019

the xls engine or camel try to access the file when the route starts

That's solved and tested in the upcoming fix for #428

@lburgazzoli
Copy link
Contributor

so I think you only need to remove the build item that includes the xslt in the final native image

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 19, 2019

you only need to remove the build item that includes the xslt in the final native image

+1, The current issue was rather meant for the JVM mode.

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 19, 2019

@lburgazzoli via chat:

well, the resource folder can contain whatever the user put there
I do mot know what the user wants
maybe the file needs to be there for any reason
we are not aware of, but by removing it
we won’t let the user any choice
it should be optional imho
maybe we can remove it bu default and have an option to include it in both the images
or vice versa

@lburgazzoli
Copy link
Contributor

@ppalaga I think this can be closed, right ?

@ppalaga
Copy link
Contributor Author

ppalaga commented Apr 6, 2020

@ppalaga I think this can be closed, right ?

Excluding unwanted resources from the runner.jar is still not possible. I'd keep this open.

@lburgazzoli
Copy link
Contributor

So guess it need to be rephrased as it is general, not linked to xslt only any-more

@ppalaga
Copy link
Contributor Author

ppalaga commented Apr 6, 2020

Feel free to change the title. XSLT is the only known use case where it matters, so I'd be fine with keeping the current title.

@ppalaga
Copy link
Contributor Author

ppalaga commented May 26, 2021

I think this is not that important after all.

@ppalaga ppalaga closed this as completed May 26, 2021
@ppalaga ppalaga added this to the No fix/wont't fix milestone May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants