Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js-dsl - Improve the interoperability with Java code #4407

Closed
essobedo opened this issue Jan 16, 2023 · 13 comments · Fixed by #4409
Closed

js-dsl - Improve the interoperability with Java code #4407

essobedo opened this issue Jan 16, 2023 · 13 comments · Fixed by #4409
Assignees
Milestone

Comments

@essobedo
Copy link
Contributor

The JavaScript DSL already supports the native mode but it is really limited in terms of interoperability with Java code, the goal of this task is to improve the code to at least support the basic use cases available in the Came code base.

@essobedo essobedo self-assigned this Jan 16, 2023
@essobedo essobedo changed the title Improve the interoperability with Java code of the js-dsl js-dsl - Improve the interoperability with Java code Jan 16, 2023
@jamesnetherton
Copy link
Contributor

The JavaScript DSL already supports the native mode

For reference:

@essobedo
Copy link
Contributor Author

Thx for sharing, I'm aware of those tickets, but maybe we could simply add a note in the documentation indicating that it is experimental instead of dropping the native mode.

I may be wrong but for me, the main purpose of Quarkus is to help us go to native so IMHO the goal of Camel Quarkus should be the same but for Camel components, don't you agree?

@jamesnetherton
Copy link
Contributor

don't you agree?

Yes, of course. But, given that the current builder container image for native apps is currently Mandrel, I'm assuming it wouldn't work for js-dsl? Because unlike GraalVM, Mandrel does not have / support the JS bits.

@essobedo
Copy link
Contributor Author

I was not aware of that thx for the info. Do you mean that It will never be supported in Mandrel? If so why not?

@essobedo
Copy link
Contributor Author

essobedo commented Jan 16, 2023

Anyway, my bad, I should have asked before, I will propose a PR since it is already done, feel free to merge it or not

@jamesnetherton
Copy link
Contributor

current builder container image for native apps is currently Mandrel

FWIW, that may eventually change. IIRC it was originally done due to some issues Quarkus encountered in GraalVM 22.3. So maybe they will revert back to GraalVM at some point....

@essobedo
Copy link
Contributor Author

Related PR #4409

@essobedo
Copy link
Contributor Author

@zakkak Hi, AFAIU the js language is not supported in Mandrel, do you know if it is planned to support it?

@zakkak
Copy link

zakkak commented Jan 16, 2023

Hi @essobedo, there are no plans for supporting it for the time being.

@essobedo
Copy link
Contributor Author

@zakkak thx for the answer, that's not good news for the project but ok

@ppalaga
Copy link
Contributor

ppalaga commented Jan 16, 2023

current builder container image for native apps is currently Mandrel

FWIW, that may eventually change. IIRC it was originally done due to some issues Quarkus encountered in GraalVM 22.3. So maybe they will revert back to GraalVM at some point....

Quarkus switched to Mandrel because of this issue in GraalVM 22.3.0 oracle/graal#5303

GraalVM 22.3.1 is due next week https://www.graalvm.org/release-notes/release-calendar/

On a more practical note, we had js-dsl native tests disabled on GH actions for some time because they simply took too long. IIRC it was like tens of minutes for this single module.

@zakkak
Copy link

zakkak commented Jan 16, 2023

GraalVM 22.3.1 is due next week https://www.graalvm.org/release-notes/release-calendar/

FYI in quarkusio/quarkus#29252 we (the Mandrel team) propose switching permanently to Mandrel. Please provide feedback in that issue if you think it's a big issue.

@essobedo
Copy link
Contributor Author

FYI in quarkusio/quarkus#29252 we (the Mandrel team) propose switching permanently to Mandrel. Please provide feedback in that issue if you think it's a big issue.

Feedback provided thanks again 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants