Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce RoutesBuilderBuildItem #526

Closed
lburgazzoli opened this issue Dec 8, 2019 · 1 comment · Fixed by #528
Closed

Re-introduce RoutesBuilderBuildItem #526

lburgazzoli opened this issue Dec 8, 2019 · 1 comment · Fixed by #528
Assignees

Comments

@lburgazzoli
Copy link
Contributor

lburgazzoli commented Dec 8, 2019

RoutesBuilderBuildItem were used to set routes builder to camel-main at build time and then we changed it to put those discovered routes to the camel registry.

It appear that it was a wrong decision as routes from the registry are not subject to Camel's DI which seems be correct as those routes are coming from i.e. a container such as ArC thus they should rely on container's DI.

Of course mixed DI i.e. CDI + CamelDI won't work.

@davsclaus what should be the right way of doing this ? One option could be that we do always apply Camel's DI to any route and let the container do it's own job.

As workaround I've implemented #525 and reported the issue to camel CAMEL-14271

@lburgazzoli lburgazzoli self-assigned this Dec 8, 2019
@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Dec 8, 2019

@davsclaus don’t mind, it should already work out of the box on other container so let’s fix it here

lburgazzoli added a commit to lburgazzoli/apache-camel-quarkus that referenced this issue Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant