Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH support #798

Closed
ppalaga opened this issue Feb 28, 2020 · 7 comments · Fixed by #1802
Closed

SSH support #798

ppalaga opened this issue Feb 28, 2020 · 7 comments · Fixed by #1802

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Feb 28, 2020

No description provided.

@squakez
Copy link
Contributor

squakez commented Aug 25, 2020

Hello there. I am interested in contributing to camel quarkus extensions, can I pick this component or anybody already worked on it by any chance?

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 25, 2020

Thanks, that's highly welcome!

This guide may help: https://camel.apache.org/camel-quarkus/latest/contributor-guide/create-new-extension.html

@ppalaga
Copy link
Contributor Author

ppalaga commented Sep 7, 2020

Any progress, @squakez ? I'd add an autogenerated JVM-only extension unless you have a test at least?

@squakez
Copy link
Contributor

squakez commented Sep 7, 2020

Not really as I am focusing on another issue on the mongodb extension, so it may take still some day before I can focus on that.

@ppalaga ppalaga added the native label Sep 7, 2020
@ppalaga
Copy link
Contributor Author

ppalaga commented Sep 7, 2020

A JVM-only extension (without a proper test) is underway.

@squakez
Copy link
Contributor

squakez commented Sep 10, 2020

@ppalaga I've started working on the native mode, and for that I made an ntegration test that I guess is valid also for the JVM mode. Do you want me to commit them and then keep ahead with the native development in parallel?

squakez added a commit to squakez/camel-quarkus that referenced this issue Sep 10, 2020
@ppalaga
Copy link
Contributor Author

ppalaga commented Sep 10, 2020

an integration test that I guess is valid also for the JVM mode

That's great and yes, the test would also be useful for the JVM mode.

Do you want me to commit them

That's tricky. Your current branch effectively declares SSH as being native ready (in catalog and on the web page), which it is not, because as I understand from what you said that test is still not passing in native mode yet?

In theory, we could commit the test under extensions-jvm/ssh/integration-test. But I do not think it is worth the effort.

From my PoV, there is no hurry to commit the test, because we just released 1.1.0 and 1.2.0 will happen in a couple of weeks. So you have enough time to finish the native support. Feel free to ask if you have specific questions.

squakez added a commit to squakez/camel-quarkus that referenced this issue Sep 16, 2020
squakez added a commit to squakez/camel-quarkus that referenced this issue Sep 17, 2020
squakez added a commit to squakez/camel-quarkus that referenced this issue Sep 17, 2020
squakez added a commit to squakez/camel-quarkus that referenced this issue Sep 17, 2020
squakez added a commit to squakez/camel-quarkus that referenced this issue Sep 18, 2020
jamesnetherton pushed a commit that referenced this issue Sep 18, 2020
@jamesnetherton jamesnetherton added this to the 1.2.0 milestone Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants