Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Groovy executions under the enforce profile #831

Closed
ppalaga opened this issue Mar 2, 2020 · 2 comments
Closed

Move Groovy executions under the enforce profile #831

ppalaga opened this issue Mar 2, 2020 · 2 comments

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Mar 2, 2020

I profiled maven builds that I execute quite often and i found that enforcer and Groovy make ~18% of the build time. enforcer is easy to skip via -Denforce=false but we do not have anything like that for Groovy. Given that our Groovy scripts serve a purpose quite similar to the enforcer, I propose to move the Groovy executions under the enforce profile, so that they all can be skipped together. WDYT?

@ppalaga
Copy link
Contributor Author

ppalaga commented Mar 2, 2020

Actually we do that in poms/build-parent/pom.xml for validate-dependencies.groovy already. So we should do that for the other two validation groovy scripts too.

@lburgazzoli
Copy link
Contributor

lburgazzoli commented Mar 2, 2020

Some time ago I did propose to make at least some of them proper enforce extensions so they would obey to the enforcer semantics, a profile would be good enough but it may be something to think about.

@oscerd oscerd closed this as completed in 13d3063 Mar 2, 2020
oscerd added a commit that referenced this issue Mar 2, 2020
Fix #831 Move Groovy executions under the enforce profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants