Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't publish integration tests during a Maven release #842

Closed
zregvart opened this issue Mar 3, 2020 · 5 comments
Closed

Don't publish integration tests during a Maven release #842

zregvart opened this issue Mar 3, 2020 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zregvart
Copy link
Member

zregvart commented Mar 3, 2020

Currently integration test artefacts such as camel-quarkus-integration-test-aws are published with the release. I think for 1.0 release we should not publish those. This can be done by adding:

<plugin>
  <artifactId>maven-deploy-plugin</artifactId>
  <configuration>
    <skip>true</skip>
  </configuration>
</plugin>

To https://github.com/apache/camel-quarkus/blob/master/integration-tests/pom.xml

@zregvart zregvart added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 3, 2020
@ppalaga
Copy link
Contributor

ppalaga commented Mar 4, 2020

Yes, publishing the itests is typically useless, but in our case, it was a deliberate decision, because they are run inside quarkus-platform https://github.com/quarkusio/quarkus-platform/tree/master/integration-tests

@ppalaga
Copy link
Contributor

ppalaga commented Mar 5, 2020

Can we close this one, @zregvart ?

@zregvart
Copy link
Member Author

zregvart commented Mar 5, 2020

Is there a use case for them being published to Maven Central, are users depending on them? If not perhaps the <skip> can be added in the release profile.

@oscerd
Copy link
Contributor

oscerd commented Mar 5, 2020

They are used here https://github.com/quarkusio/quarkus-platform/tree/master/integration-tests as dependency. So they must be released.

@ppalaga
Copy link
Contributor

ppalaga commented Mar 31, 2020

It works as designed. Feel free to reopen if you feel the design is not correct.

@ppalaga ppalaga closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants