Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camel-master branch] support ComponentNameResolver #892

Closed
lburgazzoli opened this issue Mar 16, 2020 · 13 comments
Closed

[camel-master branch] support ComponentNameResolver #892

lburgazzoli opened this issue Mar 16, 2020 · 13 comments
Assignees
Milestone

Comments

@lburgazzoli
Copy link
Contributor

See: apache/camel@2e57fd7

@lburgazzoli lburgazzoli changed the title camel-master: support ComponentNameResolver [camel-master branch] support ComponentNameResolver Mar 16, 2020
@lburgazzoli
Copy link
Contributor Author

@gnodet @jamesnetherton is someone of you already working on this ?

@jamesnetherton
Copy link
Contributor

@lburgazzoli is there anything specific that needs to be done for this?

I tested it on the master branch and it seems to be working fine.

@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented May 4, 2020

@jamesnetherton not I'm aware of, was thinking to have this process done at build time so basically have a component name resolver that returns a static list of component names but maybe it is not needed.

@jamesnetherton jamesnetherton self-assigned this May 4, 2020
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue May 4, 2020
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue May 4, 2020
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue May 4, 2020
@lburgazzoli
Copy link
Contributor Author

@jamesnetherton I think this has been already fixed right ?

@jamesnetherton
Copy link
Contributor

I need to revisit this, I started work on it but stopped for some reason that I now forget.

@jamesnetherton
Copy link
Contributor

I finally got around to taking another look at this. Is the intention that CamelContext.getComponentNames would leverage this?

If so the signature for that method and ComponentNameResolver.resolveNames has an incompatible return type. Set Vs List, so Camel would need modifying.

@lburgazzoli
Copy link
Contributor Author

@davsclaus may know

@davsclaus
Copy link
Contributor

Yeah Set would be better api as component names are unique

@davsclaus
Copy link
Contributor

@davsclaus
Copy link
Contributor

Okay changed the API in Camel 3.12

@jamesnetherton jamesnetherton added this to the 2.2.0 milestone Jul 28, 2021
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Jul 29, 2021
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Jul 29, 2021
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Jul 29, 2021
jamesnetherton added a commit to jamesnetherton/camel-quarkus that referenced this issue Jul 29, 2021
@omnipitous
Copy link

@davsclaus @jamesnetherton Dependency updates being what they are... discovering this a year later. SO: Changing from List to Set is a breaking change that should not have been included in a Minor release. Specifically, I ran into this issue because the dropwizard-camel-core package calls on this method for its health check and expects a List in response so upgrading past 3.11.0 of camel-api broke that library.

@oscerd
Copy link
Contributor

oscerd commented Sep 15, 2022

What do you mean with dependencies updates are what they are?

@omnipitous
Copy link

What do you mean with dependencies updates are what they are?

Meaning for a load of real world reasons we're not updating all of our dependencies relentlessly. *Especially when they are largely transitive dependencies of other dependencies that have interweaving version locks. (Such as Camel and Dropwizard) AND when we frequently run into breaking changes such as this one. I would love to just have Dependabot keep all of our deps current all the time BUT that's not the world of stability we live in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants