Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if JVM only extensions are used in native mode #936

Closed
jamesnetherton opened this issue Mar 20, 2020 · 5 comments · Fixed by #957
Closed

Warn if JVM only extensions are used in native mode #936

jamesnetherton opened this issue Mar 20, 2020 · 5 comments · Fixed by #957
Assignees

Comments

@jamesnetherton
Copy link
Contributor

No description provided.

@ppalaga
Copy link
Contributor

ppalaga commented Mar 23, 2020

Should that be a (a) build time warning (b) runtime warning or (c) both?

@jamesnetherton
Copy link
Contributor Author

If it's not too difficult to implement, then it can't hurt to do both.

@ppalaga ppalaga self-assigned this Mar 23, 2020
@ppalaga
Copy link
Contributor

ppalaga commented Mar 23, 2020

Is this text ok?

Extension %s may fail because it was not tested in the native mode. You may want to report about the success or failure on https://github.com/apache/camel-quarkus/issues

@ppalaga
Copy link
Contributor

ppalaga commented Mar 23, 2020

A slightly modified text referring to the list of issues filtered by the extension name

        log.warnf(
                "The %s extension was not tested in the native mode."
                        + " You may want to report about the success or failure running it in the native mode on https://github.com/apache/camel-quarkus/issues?q=is%%3Aissue+%s",
                feature, feature.replace('-', '+'));

WDYT?

@jamesnetherton
Copy link
Contributor Author

Seems ok to me.

I spotted one minor thing to correct. It reads better when you say 'in native mode' instead of 'in the native mode'.

@ppalaga ppalaga changed the title Log warning message if JVM only extensions are used in native mode Warn if JVM only extensions are used in native mode Mar 23, 2020
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants