Fix #706 Improve RuntimeCatalogConfig docs #1009
Conversation
| @@ -290,41 +290,45 @@ | |||
| @ConfigGroup | |||
| public static class RuntimeCatalogConfig { | |||
| /** | |||
| * Used to control the resolution of components catalog info. | |||
| * Whether the {@code json} resources under {@code META-INF/services/org/apache/camel/component} should be | |||
There was a problem hiding this comment.
the json is not located at META-INF/services/org/apache/camel/component but the catalog may uses service files to determine the class name of the component as the json is usually located in the same package as the component class.
Same for the other descriptions
There was a problem hiding this comment.
Thanks, I have changed the text in 9affaa1 . Could you please re-review?
| @@ -28,7 +28,8 @@ public CamelRuntimeCatalog(CamelConfig.RuntimeCatalogConfig config) { | |||
| @Override | |||
| public String modelJSonSchema(String name) { | |||
| if (!config.models) { | |||
| return null; | |||
| throw new RuntimeException( | |||
There was a problem hiding this comment.
We need to check if throwing an exception is the right thing, I do not remember if there is any assumption in the code path that invokes this method
There was a problem hiding this comment.
I am a troll, I have put it there to see who and how is actually using it :) I have fixed the tests in fc0bdf6. Are you using it in Camel K?
Fix #706