Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native images issues on Java 11 #1011

Merged
merged 6 commits into from Apr 2, 2020
Merged

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Apr 1, 2020

Fixes #1000
Fixes #1005
Fixes #999
Fixes #1010

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early comments inline.

@lburgazzoli lburgazzoli marked this pull request as ready for review April 1, 2020 15:07
@lburgazzoli
Copy link
Contributor Author

oh god, yet another case:

https://github.com/apache/camel/blob/master/components/camel-rest/src/main/java/org/apache/camel/component/rest/RestProducer.java

wondering if I'm not able to find a solution ASAP, we should add jaxb when rest is involved and see how we can fix it with camel 3.2

@ppalaga
Copy link
Contributor

ppalaga commented Apr 1, 2020

BTW, the XmlTest passes without TransformerFactorySubstitution with both GraalVM 20.0.0-java11 and 20.0.0-java8
Strange enough, the TransformerFactory is still com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl for both 20.0.0-java11 and 20.0.0-java8. But XmlTest is passing.

@lburgazzoli
Copy link
Contributor Author

yeah java 11 support in 19.3.1 seems really experimental as asvertised

@lburgazzoli
Copy link
Contributor Author

@jamesnetherton some "messaging" tests are failing here too on Java 12

@lburgazzoli
Copy link
Contributor Author

@ppalaga @jamesnetherton can you review this again ?

@lburgazzoli lburgazzoli merged commit c3ef475 into apache:master Apr 2, 2020
@lburgazzoli lburgazzoli deleted the java-11 branch April 2, 2020 11:10
@galderz
Copy link
Contributor

galderz commented Apr 6, 2020

Thanks all for working on these fixes so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants