Added native support for Kudu extension #1097 #1120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
reviewed
Apr 22, 2020
| import org.jboss.logging.Logger; | ||
|
|
||
| /** | ||
| * In order to run Kudu integration tests, {@KuduResource}, {@code KuduTest} and {@code KuduIT} should have access to: |
There was a problem hiding this comment.
About this: we need to mention Windows is not supported.
There was a problem hiding this comment.
Hey @oscerd , thanks for taking a look. Do you mean that Apache Kudu couldn't run on Windows ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Okay, I'm gonna add a comment for this. Still it should be possible to use the container based mode.
oscerd
approved these changes
Apr 22, 2020
| @@ -206,11 +206,12 @@ jobs: | |||
| sap-netweaver | |||
| servicenow | |||
| slack | |||
| - category: SQL | |||
| - category: Database | |||
There was a problem hiding this comment.
If you rename these, you also need to tweak the references in the matrix.category array.
There was a problem hiding this comment.
Ok, I found it. Thanks for the tips @jamesnetherton
|
Ok, thanks for review. I've pushed fixes on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html