Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11 Test the native mode on TravisCI #12

Merged
merged 1 commit into from Jul 2, 2019
Merged

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Jul 1, 2019

No description provided.

.travis.yml Outdated
- $GRAALVM_HOME
before_script:
- if [ ! -f "$GRAALVM_HOME/bin/java" ]; then
curl https://github.com/oracle/graal/releases/download/vm-${GRAALVM_VERSION}/graalvm-ce-linux-amd64-${GRAALVM_VERSION}.tar.gz | tar xvz -C /opt;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fine but we can eventually use the docker build provided by the quarkus maven plugin

Copy link
Contributor Author

@ppalaga ppalaga Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fine but we can eventually use the docker build provided by the quarkus maven plugin

What would be the advantage of that? (I never used it and would not know how to use it.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To always use the right version of Substrate VM for the version of quarkus we target

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good and I'd be all for using it, but I am not finding any single piece of docs how to set it up. Do you happen to have an example at hand?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppalaga ppalaga force-pushed the i11 branch 4 times, most recently from f85db72 to 5cd0952 Compare July 2, 2019 08:23
@ppalaga
Copy link
Contributor Author

ppalaga commented Jul 2, 2019

Apache org's Travis has a long queue and the job has not started yet. But the job attached to my own account passed successfully already. Note the commitId 5cd0952 in the job: https://travis-ci.org/ppalaga/camel-quarkus/builds/553174383?utm_source=github_status&utm_medium=notification

@ppalaga
Copy link
Contributor Author

ppalaga commented Jul 2, 2019

3c106ef rebased on top of the current master. It is passing on Travis attached to my fork: https://travis-ci.org/ppalaga/camel-quarkus/builds/553207744?utm_source=github_status&utm_medium=notification

I propose to merge this as is (because it is ready and working) and eventually investigate the multi-stage Docker build later. I'd like to send the package rename PR just after the current PR gets merged.

@lburgazzoli lburgazzoli merged commit 6cbe697 into apache:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants