Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce RuntimeCamelContextCustomizerBuildItem to allow to customize the camel context before it is started #1216

Merged
merged 1 commit into from May 13, 2020

Conversation

lburgazzoli
Copy link
Contributor

[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html

@lburgazzoli
Copy link
Contributor Author

@jamesnetherton I see the observability example failing, whereas the integration tests don't:

2020-05-12T14:32:54.9011253Z [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 9.72 s <<< FAILURE! - in org.acme.observability.ObservabilityTest
2020-05-12T14:32:54.9012133Z [ERROR] metrics  Time elapsed: 0.036 s  <<< FAILURE!
2020-05-12T14:32:54.9012380Z java.lang.AssertionError: 
2020-05-12T14:32:54.9012618Z 1 expectation failed.
2020-05-12T14:32:54.9012852Z Expected status code <200> but was <204>.
2020-05-12T14:32:54.9013047Z 
2020-05-12T14:32:54.9013270Z 	at org.acme.observability.ObservabilityTest.metrics(ObservabilityTest.java:38)

mind having a look ?

@lburgazzoli lburgazzoli force-pushed the ctx-customizers branch 2 times, most recently from a0db081 to e37dfcd Compare May 13, 2020 06:26
@lburgazzoli
Copy link
Contributor Author

ok so I found the reason and it has to do about when the various bits are wired to the camel context

@lburgazzoli lburgazzoli merged commit d41007e into apache:master May 13, 2020
@lburgazzoli lburgazzoli deleted the ctx-customizers branch May 13, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants