Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Camel 3.3.0 #1224

Merged
merged 6 commits into from May 15, 2020
Merged

Upgrade to Camel 3.3.0 #1224

merged 6 commits into from May 15, 2020

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented May 15, 2020

No description provided.

@ppalaga
Copy link
Contributor Author

ppalaga commented May 15, 2020

@jamesnetherton @lburgazzoli would you mind throwing a final look?

@ppalaga
Copy link
Contributor Author

ppalaga commented May 15, 2020

I have manually cancelled the push workflow

jamesnetherton
jamesnetherton reviewed May 15, 2020
View reviewed changes
Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. I left one question about version overrides.

We should bump & align spring.version too.

poms/bom/pom.xml
<dependency>
<groupId>org.mongodb</groupId>
<artifactId>bson</artifactId>
<version>${mongodb.version}</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - how do these overrides work out in the Quarkus Universe BOM?

Do we end up overriding their Mongo version? Or does their version take precedence again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point I should have documented my intention. Actually the main problem is that Quarkus does not manage bson. That causes conflicts on our side because camel-mongodb pulls a different version transitively. Best would be to let Quarkus manage bson too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd improve it in a followup if you do not mind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed quarkusio/quarkus#9330

@lburgazzoli
Copy link
Contributor

LGTM

@ppalaga
Copy link
Contributor Author

ppalaga commented May 15, 2020

bump & align spring.version

Let me do it in a followup.

@ppalaga ppalaga mentioned this pull request May 15, 2020
Closed
@ppalaga ppalaga merged commit c658f7e into master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lburgazzoli lburgazzoli lburgazzoli approved these changes

@jamesnetherton jamesnetherton jamesnetherton approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ppalaga @lburgazzoli @jamesnetherton @oscerd