Added native support for avro dataformat #1180 #1239
Conversation
...s/avro/runtime/src/main/java/org/apache/camel/quarkus/component/avro/AvroSchemaRegistry.java
Outdated
Show resolved
Hide resolved
...ployment/src/main/java/org/apache/camel/quarkus/component/avro/deployment/AvroProcessor.java
Outdated
Show resolved
Hide resolved
...s/avro/runtime/src/main/java/org/apache/camel/quarkus/component/avro/AvroSchemaRegistry.java
Outdated
Show resolved
Hide resolved
...me/src/main/java/org/apache/camel/quarkus/component/avro/AvroSchemaRegistrySubstitution.java
Outdated
Show resolved
Hide resolved
...ployment/src/main/java/org/apache/camel/quarkus/component/avro/deployment/AvroProcessor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Palaga <ppalaga@redhat.com>
Co-authored-by: Peter Palaga <ppalaga@redhat.com>
Co-authored-by: James Netherton <jamesnetherton@users.noreply.github.com>
|
@ppalaga , @jamesnetherton thanks for review guys 👍 Issues should be fixed now. |
| name: "Camel Avro" | ||
| description: "Serialize and deserialize messages using Apache Avro binary data format" | ||
| metadata: | ||
| unlisted: true | ||
| guide: "https://camel.apache.org/components/latest/avro-dataformat.html" | ||
| keywords: | ||
| - "camel" | ||
| - "messaging" | ||
| - "transformation" | ||
| guide: "https://camel.apache.org/components/latest/dataformats/avro-dataformat.html" | ||
| categories: | ||
| - "integration" |
There was a problem hiding this comment.
We recently switched to 100% generated quarkus-extension.yaml. The generator takes the input data from runtime POM and from Camel Catalog. Could you please run mvn -N cq:update-quarkus-metadata from the repo root directory and check if the result makes sense?
Based on the discussion in https://groups.google.com/forum/#!topic/quarkus-dev/uc3N_cQzG1g we stopped using keywords in most cases. They are mostly redundant because code.quarkus.io searches name and description by default anyway. So keywords make sense only in rather rare cases, if the given term is both important and occurs neither in extension name nor description. In such as case the runtime POM's property quarkus.metadata.keywords should be used, like in https://github.com/apache/camel-quarkus/blob/master/extensions/aws-ec2/runtime/pom.xml#L34
I should document these things ASAP and sorry that I have not done that yet.
There was a problem hiding this comment.
Good to know. Thanks for sharing 👍
|
Ok, I'm gonna squash and rebase that in another PR to check the build. |
I've also put a
@BuildTimeAvroDataFormatannotation that could parse the schema at build time.