Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing security configuration to azure test #1269 #1272

Closed
wants to merge 1 commit into from

Conversation

galderz
Copy link
Contributor

@galderz galderz commented May 29, 2020

Fix for #1269.

  • Security provider needs to enabled and security extension needs adding.

* Security provider needs to enabled and security extension needs adding.
@lburgazzoli
Copy link
Contributor

@jamesnetherton do we need to add those bits to the ms extensions themselves ?

@jamesnetherton
Copy link
Contributor

@lburgazzoli Yeah I was just about to suggest that. It's probably better to do something like this in AzureProcessor:

    @BuildStep
    ExtensionSslNativeSupportBuildItem activateSslNativeSupport() {
        return new ExtensionSslNativeSupportBuildItem(FEATURE);
    }

Rather than adding the properties file and the additional dependency to the tests.

@galderz
Copy link
Contributor Author

galderz commented Jun 2, 2020

@lburgazzoli @jamesnetherton Sounds good. I'll rework the PR.

@galderz
Copy link
Contributor Author

galderz commented Jun 2, 2020

Tried it and it works. Created a new PR for the new fix #1294.

@galderz galderz closed this Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants